[Addon: Knobs] - Performance Fix: added debouncing between keystrokes to speed up component rendering #5811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der function is called
CodeByAlex
requested review from
alexandrebodin,
alterx,
Hypnosphi,
leonrodenburg and
theinterned
as code owners
|
This pull request is automatically deployed with Now. |
CodeByAlex
changed the title
Codecov Report
@@ Coverage Diff @@
## next #5811 +/- ##
========================================
- Coverage 34.97% 33.98% -1%
========================================
Files 648 651 +3
Lines 9480 9477 -3
Branches 1360 1345 -15
========================================
- Hits 3316 3221 -95
- Misses 5534 5641 +107
+ Partials 630 615 -15
Continue to review full report at Codecov.
|
CodeByAlex
changed the title
|
This seems good, although I wonder if we should use debounce from lodash instead of the handrolled |
|
Good idea @tmeasday . I agree since Lodash is tried and true and is already being used in the project where debouncing occurs. I've pushed to the branch and updated the PR. Mind taking another look? |
shilman
added
the
patch:yes
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Mar 8, 2019
…debouncing [Addon: Knobs] - Performance Fix: added debouncing between keystrokes to speed up component rendering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5376
What I did
I added debouncing logic with lodash within the knob changed function to reduce the number of times a component is rendered when the user is typing. The knob changed functionality will only be called if there is a delay of 150ms(slightly faster than the average time between keypress) during user typing. The previous version re-rendered the component upon each keypress. This will help increase performance and is seen mostly when running large components within storybook.
For more information about this PR, please refer to #5376
How to test